-
Notifications
You must be signed in to change notification settings - Fork 0
Implementation Workflow
The Implementation Workflow takes an approved LLD through coding, testing, review, and merge.
graph TD
subgraph Input["TRIGGER"]
AP["LLD APPROVED"]
end
subgraph Setup["ISOLATION"]
W["Create Git Worktree"]
D["Install Dependencies"]
end
subgraph Build["IMPLEMENTATION"]
C["Write Code"]
T["Run Tests"]
F["Fix Issues"]
end
subgraph Report["DOCUMENTATION"]
IR["Generate<br/>Implementation Report"]
TR["Generate<br/>Test Report"]
end
subgraph Review["VERIFICATION"]
G{"Gemini<br/>Reviews"}
V["Verdict Issued"]
end
subgraph Ship["DELIVERY"]
PR["Create Pull Request"]
M["Merge"]
CL["Cleanup Worktree"]
end
AP --> W
W --> D
D --> C
C --> T
T -->|"Failures"| F
F --> T
T -->|"Pass"| IR
IR --> TR
TR --> G
G --> V
V -->|"BLOCK"| C
V -->|"APPROVE"| PR
PR --> M
M --> CL
Every implementation happens in an isolated worktree. This is non-negotiable.
Multiple agents work on AssemblyZero simultaneously. Direct commits to main would cause conflicts and corruption.
# Create worktree for issue #123
git worktree add ../AssemblyZero-123 -b 123-feature-name
cd ../AssemblyZero-123
poetry install| Change Type | Worktree Required |
|---|---|
.py, .js, .ts files |
Yes |
pyproject.toml, package.json
|
Yes |
| Infrastructure, deployment | Yes |
| Bug fixes (even "quick" ones) | Yes |
Documentation only (docs/**/*.md) |
No |
CLAUDE.md updates |
No |
The approved LLD specifies:
- Files to create/modify
- API contracts
- Data models
- Test requirements
Claude implements according to the LLD. Deviations require explanation in the implementation report.
graph TD
T["Write Test"]
R["Run Test<br/>(Fails)"]
I["Implement"]
P["Run Test<br/>(Passes)"]
N["Next Test<br/>(repeat from top)"]
T --> R
R --> I
I --> P
P --> N
If tests are skipped, they must be audited:
SKIPPED TEST AUDIT:
- [SKIPPED] "test_firefox_extension"
- Verifies: Extension loads in Firefox
- Skip reason: Firefox not installed in CI
- Critical: YES (core feature)
- Alt verification: NONE
- Status: UNVERIFIED ← BLOCKS MERGEUNVERIFIED critical tests block merge.
Two reports are required before Gemini review:
# Implementation Report: Feature Name
## Issue Reference
[#123](https://github.com/...)
## Files Changed
| File | Change Type | Description |
|------|-------------|-------------|
| src/feature.py | Added | Main implementation |
| tests/test_feature.py | Added | Unit tests |
## Design Decisions
Why specific approaches were chosen.
Any deviations from LLD with justification.
## Known Limitations
What doesn't work or is incomplete.
## Testing
How changes were tested beyond unit tests.# Test Report: Feature Name
## Test Command
pytest tests/test_feature.py -v
## Full Output
[COMPLETE output - not paraphrased]
## Coverage
| File | Lines | Coverage |
|------|-------|----------|
| src/feature.py | 120 | 87% |
## Skipped Tests
| Test | Reason | Critical |
|------|--------|----------|
| test_edge | Mock unavailable | No |Reports and diff are submitted to Gemini for review.
| Category | Questions |
|---|---|
| Code Quality | Readable? Maintainable? |
| Pattern Compliance | Follows project conventions? |
| Test Coverage | Adequate for changes? |
| Security | No vulnerabilities introduced? |
| Documentation | Updated appropriately? |
| LLD Compliance | Implements what was designed? |
| Verdict | Action |
|---|---|
| APPROVE | Proceed to PR creation |
| BLOCK | Fix issues, regenerate reports, re-submit |
| Outcome | Rate |
|---|---|
| First-pass APPROVE | 75-85% |
| After 1 revision | 95%+ |
| After 2+ revisions | 99%+ |
Once Gemini approves:
gh pr create --title "feat: implement feature (#123)" --body "..."## Summary
- What this PR does
- Related issue: #123
## Changes
- List of changes
## Test Plan
- How to verify
## Gemini Verdict
[APPROVED] - Implementation passed reviewAfter PR merge:
# 1. Archive lineage
python tools/archive_worktree_lineage.py --worktree ../AssemblyZero-123 --issue 123
# 2. Remove worktree
git worktree remove ../AssemblyZero-123
# 3. Delete branches
git branch -d 123-feature-name
git push origin --delete 123-feature-name
# 4. Pull changes
git pullCleanup is mandatory. Stale worktrees and branches confuse future agents.
The lineage directory grows to include implementation artifacts:
docs/lineage/archived/{issue}-lld/
├── 001-issue.md
├── 002-draft.md
├── 003-verdict.md
├── 004-draft.md
├── 005-verdict.md
├── 006-final.md # Approved LLD
├── 007-approved.json
├── 008-impl-report.md # Implementation report
├── 009-test-report.md # Test report
├── 010-impl-verdict.md # Gemini's code review
└── 011-pr.md # PR link and merge info
The regression guard protects the implementation workflow:
- Regression test execution before merge
- Baseline comparison against main
- Automatic issue creation for new failures
- Go/no-go signals for risky merges
| Metric | Target | Warning |
|---|---|---|
| Implementation time | < 4 hours | > 8 hours |
| Test coverage | > 80% | < 60% |
| First-pass approval | > 80% | < 60% |
| Revisions needed | < 1.5 | > 2.5 |
| Cleanup completed | 100% | < 100% |
| Reason | Frequency | Prevention |
|---|---|---|
| Missing test coverage | 40% | TDD approach |
| Security issues | 25% | Security section in LLD |
| Pattern violations | 20% | Code review before submit |
| Missing docs | 10% | Documentation checklist |
| Other | 5% | - |
- Requirements Workflow - How LLDs get approved
- Governance Gates - All gates explained
- Gemini Verification - Multi-model architecture
- Dramatis Personae - Commander Vimes and The Watch
"'The law is the law,' said Carrot. 'That's what makes it the law.'" — Terry Pratchett, Men at Arms
| You are... | Go to |
|---|---|
| Engineering Leader | Why AssemblyZero? |
| AI Strategy / Ops | AI Strategy & Operations |
| Technical Architect | Technical Architecture |
| Security & Compliance | Secret Guard Architecture |
| Practitioner | Quick Start |
- March 2026 Velocity — 206 issues in 21 days
- Dramatis Personae
- Multi-Agent Orchestration
- Gemini Verification
- Governance Gates
- How AssemblyZero Learns
- LangGraph Evolution
- The Pipeline (Idea → Tested Code)
- Requirements Workflow
- Implementation Workflow
- The Scout
- Worktree Isolation
- Secret Guard Architecture
- Fleet Security Audit
- Agent Instruction Hierarchy
- Cerberus PR Governance
- Branch Protection at Scale