Skip to content

support C++23 import std on unordered_dense module #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
martinus merged 6 commits into from
Oct 27, 2025
Merged

support C++23 import std on unordered_dense module #95

martinus merged 6 commits into from
Oct 27, 2025

Conversation

@Arthapz
Copy link
Contributor

@Arthapz Arthapz commented Oct 20, 2023 •
edited
Loading

This PR add support of import std for user that want it
it rely on the define ANKERL_UNORDERED_DENSE_STD_MODULE to disable #include of std headers and enable std module

i changed all uint_ to std::uint*_t and size_t to std::size_t because c++23 std module only export std namespace
i added #include <stdlib.h> because C++23 std module doesn't export macro (needed for UINT64_C)

@Arthapz Arthapz force-pushed the main branch 4 times, most recently from 4162271 to 1446989 Compare October 20, 2023 11:43
@Arthapz Arthapz force-pushed the main branch 4 times, most recently from 82f820a to 9df0549 Compare April 6, 2025 18:34
@Arthapz Arthapz force-pushed the main branch 3 times, most recently from 49fa34d to b45d409 Compare April 19, 2025 19:27
@martinus
Copy link
Owner

martinus commented Oct 7, 2025

Hi, sorry for the long wait. Are you still interested in this?

@Arthapz
Copy link
Contributor Author

Arthapz commented Oct 21, 2025

Hi, sorry for the long wait. Are you still interested in this?

hi, no problem and yes :)
i reworked it and rebased it on master, the xmake.lua is only here for compilation test purpose, i'll remove it

@martinus
Copy link
Owner

martinus commented Oct 21, 2025

Please add a // NOLINT(cppcoreguidelines-macro-usage) to the macro definition so the linter is happy

Also, do you think you can add a build steps to main.yml so a build and tests are run with C++23? I'm not sure if that is easily possible though.

@Arthapz Arthapz force-pushed the main branch 3 times, most recently from 2649be9 to bc09db8 Compare October 26, 2025 16:40
@Arthapz Arthapz force-pushed the main branch 5 times, most recently from 2df8a71 to 3d59984 Compare October 26, 2025 17:57
@Arthapz Arthapz force-pushed the main branch 2 times, most recently from ed5dd56 to c6ef4b0 Compare October 26, 2025 18:03
@Arthapz
Copy link
Contributor Author

Arthapz commented Oct 26, 2025 •
edited
Loading

Please add a // NOLINT(cppcoreguidelines-macro-usage) to the macro definition so the linter is happy

Also, do you think you can add a build steps to main.yml so a build and tests are run with C++23? I'm not sure if that is easily possible though.

i added the nolint comment and enable C++23 in CI for all platforms (but not for -sanitizers variant)
enabled the support of module compilation in cmakelists
and added a linux-modules and window-modules jobs that compile the example in C++20 mode with the module (but not with the std module as support in CMake is experimental, but i tested it with the xmake file)

@Arthapz
Copy link
Contributor Author

Arthapz commented Oct 26, 2025 •
edited
Loading

https://github.com/Arthapz/unordered_dense/actions/runs/18821789403

@martinus martinus merged commit 40a6724 into martinus:main Oct 27, 2025
28 checks passed
@martinus
Copy link
Owner

martinus commented Oct 27, 2025 •
edited
Loading

Awesome, thanks for your work! I'll create a new release for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Arthapz @martinus