Adds a clang-tidy linter #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a clang-tidy linter to the project to perform static analysis on the unordered_dense.h header file. The linter is integrated into the CI workflow and modernizes the codebase by applying C++ best practices and fixing various style issues.
Key changes:
- Integrates clang-tidy linting into the CI workflow with a Python script
- Modernizes C++ template metaprogramming using newer type traits syntax
- Fixes various code style issues identified by clang-tidy checks
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/lint/lint-clang-tidy.py | New Python script to run clang-tidy on the header file |
| .clang-tidy | Updated configuration with comprehensive checks and proper header filtering |
| .github/workflows/main.yml | Integrates clang-tidy into CI workflow |
| include/ankerl/unordered_dense.h | Modernizes code with C++17 features and fixes style issues |
| test/unit/include_only.cpp | Adds NOLINT comment to suppress include-cleaner warning |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
0815375 to
39c037d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.