Skip to content

Streaming encoder#74

Merged
marshallpierce merged 20 commits intomasterfrom
brianm-encoder
Oct 28, 2018
Merged

Streaming encoder#74
marshallpierce merged 20 commits intomasterfrom
brianm-encoder

Conversation

@marshallpierce
Copy link
Copy Markdown
Owner

Supersedes #56.

cc @brianm @nox

@igor-raits
Copy link
Copy Markdown
Contributor

Wait, no DecodeWriter?

@marshallpierce
Copy link
Copy Markdown
Owner Author

Well, this PR is entitled "Streaming encoder"... ;) One thing at a time. Most of this logic can eventually be shared with a Write that encodes, and there will also eventually be Read impls as well.

@marshallpierce
Copy link
Copy Markdown
Owner Author

@nox does this suit your use case?

@nox
Copy link
Copy Markdown
Contributor

nox commented Oct 27, 2018

Yes!

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #74 into master will decrease coverage by 0.68%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   97.31%   96.63%   -0.69%     
==========================================
  Files          10       12       +2     
  Lines        1044     1368     +324     
==========================================
+ Hits         1016     1322     +306     
- Misses         28       46      +18
Impacted Files Coverage Δ
src/lib.rs 100% <ø> (ø) ⬆️
src/write/encoder.rs 86.41% <86.41%> (ø)
src/write/encoder_tests.rs 97.11% <97.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0794fc6...37e8402. Read the comment docs.

@marshallpierce marshallpierce merged commit 84ad275 into master Oct 28, 2018
@brianm
Copy link
Copy Markdown
Contributor

brianm commented Oct 29, 2018

Yea!

@nox
Copy link
Copy Markdown
Contributor

nox commented Nov 13, 2018

This may be broken.

servo/servo#22147 (comment)

@marshallpierce
Copy link
Copy Markdown
Owner Author

Looking into it

@nox
Copy link
Copy Markdown
Contributor

nox commented Nov 13, 2018

@marshallpierce found out that the problem is probably in the png crate, which uses io::Write::write without checking how many bytes were actually written.

I've opened image-rs/image-png#94. There is no issue with the base64 crate AFAICT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants