Skip to content

no_std support#62

Closed
astro wants to merge 2 commits intomarshallpierce:masterfrom
astro:no_std
Closed

no_std support#62
astro wants to merge 2 commits intomarshallpierce:masterfrom
astro:no_std

Conversation

@astro
Copy link
Copy Markdown

@astro astro commented Jun 14, 2018

Could be useful for embedded systems.

Thank you for this project!

@marshallpierce
Copy link
Copy Markdown
Owner

Thanks for this; I'll take a look. Unfortunately it will probably take me several weeks at least to get to this. I'm moving right now, so my spare time goes towards putting things in cardboard boxes.

@astro
Copy link
Copy Markdown
Author

astro commented Jun 14, 2018

No hurries. Thanks for the headsup!

@linkmauve
Copy link
Copy Markdown
Contributor

This looks correct to me, I also tested it on no_std (but with alloc available) and it works as expected, thanks!

In environments without an allocator, the API provides only the
`encode_config_slice()` and `decode_config_slice()` functions (which
do not use the dynamically-sized `Vec` type) and the
`strip_whitespace` config must be disabled.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unpleasant interplay of features is yet more evidence to me that line wrapping (and its dual, whitespace stripping) are a mistake to include, at least at this level. Maybe a base64::ext should contain helper functions to do that stuff after the fact. This would also simplify #56.

@marshallpierce
Copy link
Copy Markdown
Owner

Line wrapping is gone, and I'm going to remove whitespace stripping as well, which should make this tidier to implement.

@CryZe
Copy link
Copy Markdown
Contributor

CryZe commented Aug 1, 2019

What's the status of this?

@marshallpierce
Copy link
Copy Markdown
Owner

I'd like to have this feature shipped; it's just waiting on my free time.

Now that the alloc crate is stable in 1.36, we could use that, and I'd be happy to bump the minimum version to 1.36 to ship that feature. (This would also answer the version question in #110 ).

If you feel like picking up the pieces from this long since bitrotted PR, that'd be great, but if not, it'll be several months likely until I can dedicate the time to do it myself.

@marshallpierce
Copy link
Copy Markdown
Owner

This is now done via #111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants