Skip to content

Conversation

@hong-duc
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets #171
License MIT

Description

This will fix #171 but it will create another issues is scrolling is now handled by codemirror instead of the container.

Like this
issues_171

--

Please, don't submit /dist files with your PR!

@Jocs Jocs requested a review from fxha March 23, 2019 13:13
Copy link
Contributor

@fxha fxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jocs This patch fixes the issue when the height is corrected but it will add the scrollbar to codemirror (like in the picture) and not to the right. What's your opinion?

@Jocs
Copy link
Member

Jocs commented Mar 24, 2019

I think the scroll bar is not very beautiful in the middle, there should be a better solution?

@hong-duc
Copy link
Author

I will think of someway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants