Skip to content

Conversation

@MrHeer
Copy link
Contributor

@MrHeer MrHeer commented Dec 12, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
New tests added? not needed
Fixed tickets Fixes #1698
License MIT

Description

fix bold or italic hyperlinks can't be opened through Cmd+Click

@MrHeer
Copy link
Contributor Author

MrHeer commented Dec 12, 2019

I know it ugly, but I can't find a better solution.

@Jocs
Copy link
Member

Jocs commented Dec 12, 2019

@MrHeer Your PR solve this syntax [**strong**](), it maybe also has other cases like:

[`inline code`]()

[~~line through~~]()

[**`inline and strong`**]()

So, get parentNode is not enough?

@MrHeer MrHeer requested a review from Jocs December 21, 2019 00:01
@Jocs Jocs merged commit 632eac3 into marktext:develop Feb 6, 2020
@Jocs
Copy link
Member

Jocs commented Feb 6, 2020

@MrHeer Thanks for your contribution!

@MrHeer MrHeer deleted the fix-hyperlinks branch February 7, 2020 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can not open bold or italic hyperlinks through Cmd+Click

2 participants