Skip to content

Conversation

@DanEble
Copy link
Contributor

@DanEble DanEble commented Nov 22, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? (what's this?)
Deprecations? no
New tests added? no
Fixed tickets #1679
License MIT

Description

This fixes two problems with the Find Next and Find Previous actions:

  1. Shortcut key collision: use ⌘G and ⇧⌘G on macOS, and use F3 and ⇧F3 on other platforms. I have only tested this change on macOS.
  2. Typo: "fineNext" for "findNext"

@DanEble
Copy link
Contributor Author

DanEble commented Nov 23, 2019

It looks like there might be something wrong in Travis that is unrelated to this change.

@Jocs
Copy link
Member

Jocs commented Nov 24, 2019

@fxha is it OK to use F3 and ⇧F3 on other platforms. ?

@Jocs Jocs requested a review from fxha November 24, 2019 15:36
Copy link
Contributor

@fxha fxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanEble Thank your for the change 👍. LGFM, please update the documentation too.

It looks like there might be something wrong in Travis that is unrelated to this change.

Yes, there are some issues with accessing GitHub from time to time.

@fxha fxha merged commit f0e548d into marktext:develop Nov 27, 2019
@DanEble DanEble deleted the dev/issue-1679-osx-find-next branch November 27, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants