-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
A task checked should update related task #1737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I need to take a moment to think about |
|
Can you give me some test case? @Jocs |
|
@MrHeer I just think these two cases: - [x] foo
- [ ] bar
- [ ] zar
---
- [x] - [x] - [x] foo
- [ ] bar
- [ ] zar
|
|
The second will be less use, but it is a legal grammar I think. |
|
I mean I can't understand their logic, I don't known how to update the others status after a task checked |
|
Distinguishing parent-child relationships by DOM structure? |
|
Thank you, I'll try to sovle |
92be452 to
8f53b9e
Compare
|
@Jocs If distinguishing parent-child relationships by DOM structure, the logic is right. |
|
I would love to have this feature in Mark Text. @MrHeer Is there an issue that is blocking this PR from your side? If it is because of the failing CI build, it seems to me that it is failing due to an PR-independent build error related to vscode-ripgrep. |
|
@renehummen The author think my code had some problems, but I'm not clear that. |
@MrHeer Can this PR also handle the following cases? ... where toggling task completion leads to the following behavior:
I am not entirely sure what the best behavior for untoggling would be. I would suggest:
|
|
@MrHeer I think the best option would be to add a settings option for this feature, so the user can decide whether the feature should be enabled or all checkboxes must be checked. |
|
@fxha Thank you, I will add a settings option for this feature when I have time. |
8f53b9e to
0bda939
Compare
|
@fxha Hi, I have updated, can you review? |
|
@MrHeer Sorry for reply so late, Did you have finished this PR, so we can review it? |
|
Yes, you can review it. |
|
I have reviewed the code again, and run it locally, and found a small problem. When initializing the editor, |
|
@Jocs Thank you very much. I have updated, please review again. |
1. fix autoCheck was not passed to the editor 2. put getParentCheckBox and cumputeChecboxStatus functions in utils folder. 3. put setCheckBoxState, updateParentsCheckBoxState, updateChildrenCheckBoxState and listItemCheckBoxClick methods in clickCtrl.js file.
f4d37d8 to
9a27279
Compare
|
@MrHeer Thanks very much for your contribution! |
|
It's my pleasure. |


Description
Auto update others checked state while change a task