Skip to content

Conversation

@fxha
Copy link
Contributor

@fxha fxha commented Oct 22, 2019

Q A
Bug fix? yes
New feature? yes
Fixed tickets #349, #354, #1479
License MIT

Description

  • Added export/print settings
  • Added custom and user-defined themes for exporting/printing
  • Fixed code block overflow in PDF
  • Known issues:
    • The blockquote border is rendered over header/footer when it's over multiple pages.
    • Emojis may be black when exporting on Linux if sans-serif or serif is defined because the system fallback font is used instead colored emojis. Noto Color Emoji cannot overwrite this.
    • Adding Noto Color Emoji to font fallback list result in files with multiple MB (because the font is included in PDF) and the emojis look weird due to the point above.
  • Improvements: Print in another window for better performance - you could export/print and write at the same time.
  • To-do in another PR: Documentation

@fxha fxha requested a review from Jocs October 22, 2019 19:46
@Jocs
Copy link
Member

Jocs commented Oct 23, 2019

Print in another window for better performance - you could export/print and write at the same time.

Good idea, maybe we can use a headless Electron window for export/print.

@Jocs
Copy link
Member

Jocs commented Oct 23, 2019

Nice features and some UI suggestion:

  1. Put Info tab content bellow Export Options, and no need to give it an individual tab. Because it has no settings of export PDF/HTML.
    屏幕快照 2019-10-23 上午11 28 30

  2. Narrow the vertical scroll bar, maybe 5px is ok? or just hide it?

屏幕快照 2019-10-23 上午11 29 44

@fxha
Copy link
Contributor Author

fxha commented Oct 23, 2019

  1. Put Info tab content bellow Export Options, and no need to give it an individual tab. Because it has no settings of export PDF/HTML.
    屏幕快照 2019-10-23 上午11 28 30

I prefer to have a separate start page and not the options on the first page. @Jocs What do you think about that?

Narrow the vertical scroll bar, maybe 5px is ok? or just hide it?

I'll narrow the bar a bit.

@Jocs
Copy link
Member

Jocs commented Oct 24, 2019

I prefer to have a separate start page and not the options on the first page.

What do you mean a separate start page?

@fxha
Copy link
Contributor Author

fxha commented Oct 24, 2019

I prefer to have a separate start page and not the options on the first page.

What do you mean a separate start page?

A separate tab like the Info tab in the image above - keep it as it is.

@Jocs
Copy link
Member

Jocs commented Oct 24, 2019

截屏2019-10-24下午11 05 17

We can borrow the UI from Chrome print setting modal in the future, and show a preview page on the left.

@fxha
Copy link
Contributor Author

fxha commented Oct 24, 2019

That's a good idea and also brings better export/print performance because it's doesn't block the editor. BTW page number are currently not supported because it's not possible with pure CSS or current Electron.

@Jocs
Copy link
Member

Jocs commented Oct 25, 2019

That's a good idea and also brings better export/print performance because it's doesn't block the editor.

Yes, you mean a separate window, it will bring better performance.

@Jocs Jocs merged commit e5dc8f1 into develop Oct 25, 2019
@Jocs
Copy link
Member

Jocs commented Oct 26, 2019

@fxha I found that I can not set the margin/padding in the export setting now, and header/footer also can not be setted?

@fxha
Copy link
Contributor Author

fxha commented Oct 26, 2019

I found that I can not set the margin/padding in the export setting now, and header/footer also can not be setted?

Could you please explain the issue or provide a gif? Any exceptions or so?

@fxha fxha deleted the pdf-options branch October 26, 2019 14:37
@Jocs
Copy link
Member

Jocs commented Oct 26, 2019

Could you please explain the issue or provide a gif? Any exceptions or so?

It works well now, I export it in the morning, the Page and Header & Footer seems disappeared, but I can not reproduce it again.

屏幕快照 2019-10-26 下午10 58 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants