fix: #1418 Set file watch option usePolling to true on macOS #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fxha
reviewed
Oct 2, 2019
Contributor
fxha
left a comment
There was a problem hiding this comment.
I still guess that it's an upstream issue but if it's the only way to fix 👍 We need to observe this because polling is bad idea for performance and we may have to outsource the watcher to a separate process. In my tests on larger folders polling used 5-10% CPU usage.
fxha
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Description of the bug or feature]
--
Please, don't submit
/distfiles with your PR!This change is