Skip to content

Support RegExp search and replace in file edit. #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jocs merged 8 commits into from
Oct 6, 2019
Merged

Support RegExp search and replace in file edit. #1422

Jocs merged 8 commits into from
Oct 6, 2019

Conversation

@Jocs
Copy link
Member

@Jocs Jocs commented Oct 1, 2019 •
edited
Loading

Q A
New feature? yes
Fixed tickets #356
License MIT

Description

  • Search string
  • Case sensitive
  • Whole word match
  • Use RegExp to search

屏幕快照 2019-10-03 上午12 33 36

This change is Reviewable

@Jocs Jocs added the 🐜 in progress This issue is in progress label Oct 1, 2019
@Jocs Jocs changed the title [WIP] Support RegExp search and replace in file edit. Support RegExp search and replace in file edit. Oct 2, 2019
@Jocs Jocs removed the 🐜 in progress This issue is in progress label Oct 2, 2019
@Jocs Jocs requested a review from fxha October 2, 2019 16:32
fxha
fxha reviewed Oct 2, 2019
View reviewed changes
Copy link
Contributor

@fxha fxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing and found an issue when selecting a word, pressing Ctrl+F and then the searcher don't find any matches. If I write the selected word or paste it into the search bar all works fine.

@Jocs Jocs requested a review from fxha October 3, 2019 02:05
Jocs
Jocs commented Oct 3, 2019
View reviewed changes
@Jocs
Copy link
Member Author

Jocs commented Oct 3, 2019

@fxha

I did some testing and found an issue when selecting a word, pressing Ctrl+F and then the searcher don't find any matches. If I write the selected word or paste it into the search bar all works fine.

fixed.

@Jocs Jocs merged commit 4d728a5 into develop Oct 6, 2019
@Jocs Jocs deleted the fix-issue-356 branch October 6, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fxha fxha fxha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jocs @fxha