Add support in Commons CSV for tracking byte positions during parsing#6
Merged
DarrenJAN merged 5 commits intoNov 5, 2024
Merged
Conversation
yunzvanessa
requested changes
Oct 31, 2024
yunzvanessa
left a comment
There was a problem hiding this comment.
Hi Yuzhan,
The functionality looks good. Two things to focus on:
- Please go over all the comments you added since we would like to formalize it and attempt for a PR against the central repo.
- Please confirm the copyright info with Shawna and update them in the source files you are changing accordingly.
|
Can you also investigate the failing checks below and make sure they are okay? |
Author
|
yunzvanessa
reviewed
Nov 4, 2024
yunzvanessa
requested changes
Nov 4, 2024
yunzvanessa
left a comment
There was a problem hiding this comment.
Hi Yuzhan,
Just a minor detail for you to change. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that it is required to use Java 11 to build and run tests.
Here are summaries of the modifications:
Test result:


mvn
Pass unit tests and other restrictions