Skip to content

CSV-196-master: More changes#16

Merged
DarrenJAN merged 1 commit into
marklogic:CSV-196-masterfrom
DarrenJAN:add-changes-Dec26
Dec 27, 2024
Merged

CSV-196-master: More changes#16
DarrenJAN merged 1 commit into
marklogic:CSV-196-masterfrom
DarrenJAN:add-changes-Dec26

Conversation

@DarrenJAN

Copy link
Copy Markdown

Changes:

  1. New private elements do not need a Javadoc since tag.
  2. Return type of getCharByte is int
  3. Change ** getCharBytes** to getEncodedCharLength
  4. Add Javadoc @param for enableByteTracking
  5. CSVRecord: Remove the old constructors and adapt the existing test.
  6. Change characterByte to bytePosition @yunzvanessa How do you think this change?

Test:
mvn
image

@yunzvanessa yunzvanessa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@DarrenJAN DarrenJAN merged commit bdd152f into marklogic:CSV-196-master Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants