Add support in Commons CSV for tracking byte positions during parsing#10
Merged
DarrenJAN merged 1 commit intoNov 7, 2024
Conversation
…apache#9) Add support in Commons CSV for tracking byte positions during parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support in Commons CSV for tracking byte positions during parsing.
Summary of Modifications
Test Data Files: Added new test data files, and updated pom.xml to exclude these files from RAT checks, avoiding unapproved license checks.
CSVParser class:
Constructor Enhancements
a. Added support for an optional parameter -- String encoding--, which specifies the encoding to use for the reader.
CSVRecord class
private long characterByte: start byte position of this record
Add new Constructor: support track byte positions in record class
ExtendedBufferedReader Class:
private long bytesRead: Tracks the number of bytes read so far.
private long bytesReadMark: Stores the marked byte position.
CharsetEncoder encoder: Encoder used to calculate byte size of characters.
getCharBytes(int current): This function calculates character bytes based on UTF-8 encoding. Note: it only supports UTF-8 due to the encoding algorithm used. Full encoding can be supported and we just need more effort on this.
reset() and mark() Methods: Enhanced to prevent consuming characters and bytes unintentionally.
Test result:


mvn
Pass unit tests and other restrictions