fix: add aria-label to inline edit inputs for accessibility#899
Merged
marketcalls merged 1 commit intomarketcalls:mainfrom Feb 11, 2026
Merged
Conversation
marketcalls
approved these changes
Feb 11, 2026
Owner
marketcalls
left a comment
There was a problem hiding this comment.
Clean, correct, and complete. All 5 inline edit inputs across 3 admin pages are covered with well-crafted dynamic aria-labels. No security concerns — React treats aria-label as a string attribute (no HTML parsing), and the interpolated values (exchange/symbol names) are already visible in the UI. Good work going beyond the original scope to cover FreezeQty and Holidays as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-labelto time inputs in MarketTimings inline edit modearia-labelto freeze quantity input in FreezeQty inline edit modearia-labelto special session time inputs in Holidays dialogCloses #890
What this fixes
Screen readers couldn't identify inline edit input fields because they had no
aria-labelor associated<label>element.This violates WCAG 2.1 guidelines 1.3.1 (Info and Relationships) and 3.3.2 (Labels or Instructions).
Each label is dynamic and includes the exchange/symbol name for better context (e.g., "Start time for NSE", "Freeze quantity for NIFTY").
Files changed
frontend/src/pages/admin/MarketTimings.tsx— 2 inputs (start time, end time)frontend/src/pages/admin/FreezeQty.tsx— 1 input (freeze quantity)frontend/src/pages/admin/Holidays.tsx— 2 inputs (special session start/end time)Summary by cubic
Added aria-labels to inline edit inputs so screen readers can identify them. Labels are dynamic and include the exchange or symbol for context.
Written for commit 261df58. Summary will update on new commits.