Skip to content

chore: clean up rules#3791

Merged
UziTech merged 1 commit intomarkedjs:masterfrom
UziTech:cas-insensitive-protocol
Oct 7, 2025
Merged

chore: clean up rules#3791
UziTech merged 1 commit intomarkedjs:masterfrom
UziTech:cas-insensitive-protocol

Conversation

@UziTech
Copy link
Member

@UziTech UziTech commented Oct 7, 2025 •
edited
Loading

Description

clean up some rules code

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Oct 7, 2025

@UziTech is attempting to deploy a commit to the MarkedJS Team on Vercel.

A member of the Team first needs to authorize it.

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 7, 2025

Summary of Changes

Hello @UziTech, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a minor code cleanup within the src/rules.ts file. It centralizes a repeated regular expression pattern used for matching case-insensitive http(s) and ftp protocols into a new constant. This change aims to improve the readability and maintainability of the parsing rules by reducing duplication and making the regex definitions more consistent.

Highlights

  • Refactoring Protocol Regex: Extracted a common case-insensitive regular expression for http(s) and ftp protocols into a new constant _caseInsensitiveProtocol.
  • Improved Readability: Replaced duplicated inline regex patterns with the new _caseInsensitiveProtocol constant in the url and text parsing rules, enhancing code clarity and maintainability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@vercel
Copy link

vercel bot commented Oct 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marked-website Ready Ready Preview Comment Oct 7, 2025 3:28am

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a good refactoring by extracting a duplicated regular expression for URL protocols into a constant, which improves code maintainability and readability. I have one suggestion for a future improvement to make the regex even more concise and idiomatic by using the case-insensitive flag, which would involve changes slightly outside the scope of this PR's diff.

@UziTech UziTech merged commit 7b4c520 into markedjs:master Oct 7, 2025
8 checks passed
@UziTech UziTech deleted the cas-insensitive-protocol branch October 7, 2025 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@UziTech @styfle