Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
styfle
reviewed
Jul 13, 2024
| module.exports = { | ||
| markdown: `[x]:${' '.repeat(1500)}x ${' '.repeat(1500)} x`, | ||
| html: `<p>[x]:${' '.repeat(1500)}x ${' '.repeat(1500)} x</p>`, | ||
| html: `<p>[x]:${' '.repeat(1500)}x ${' '.repeat(1500)} x</p>` |
Member
There was a problem hiding this comment.
Personally, I like trailing commas
Member
Author
There was a problem hiding this comment.
Me too. I just kept the rules the same as before.
I will try changing the rules in a follow up pr. There will be a lot of src code changes
styfle
reviewed
Jul 14, 2024
| "build:docs": "npm run build && node docs/build.js", | ||
| "build:types": "tsc && dts-bundle-generator --project tsconfig.json -o lib/marked.d.ts src/marked.ts && dts-bundle-generator --project tsconfig.json -o lib/marked.d.cts src/marked.ts", | ||
| "build:man": "marked-man man/marked.1.md > man/marked.1", | ||
| "rollup": "rollup -c rollup.config.js" |
Member
There was a problem hiding this comment.
Whats changing in the scripts here? Is it just the order?
Member
Author
There was a problem hiding this comment.
Ya just reordering alphabetically
styfle
approved these changes
Jul 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update eslint to v9
This does mean removing standard since it is no longer maintained
We could use neostandard which is the successor but I don't see why we wouldn't think the same thing will happen to it in the future. Just copying the config seems to be the best option to continue with the same rules.
Maybe a future PR can slim down the rules a bit. Personally I prefer only using
eslint:recommendedandtypescript-eslint:recommendedsince it is simpler.Contributor
Committer
In most cases, this should be a different person than the contributor.