Conversation
|
@UziTech is attempting to deploy a commit to the MarkedJS Team on Vercel. A member of the Team first needs to authorize it. |
Summary of ChangesHello @UziTech, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical security vulnerability by ensuring that image alt text is properly escaped when rendered. This prevents malicious scripts from being injected and executed via unescaped alt attributes, thereby enhancing the overall security of the application. The change includes new tests to confirm the fix and prevent regressions. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request addresses a critical cross-site scripting (XSS) vulnerability by properly escaping the alt text of images. The change in src/Renderer.ts correctly applies the escape function to the image's alt attribute, preventing malicious content from being executed. The addition of new test files (image_alt.md and image_alt.html) provides a solid regression test for this vulnerability. The fix is correct, concise, and follows best practices for handling user-provided content in HTML attributes. The change is excellent and I have no suggestions for improvement.
| href = cleanHref; | ||
|
|
||
| let out = `<img src="${href}" alt="${text}"`; | ||
| let out = `<img src="${href}" alt="${escape(text)}"`; |
There was a problem hiding this comment.
I'm not sure if escape() is the right thing to use here because its deprecated.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/escape
But looks like the title below also does the same thing so we can go with it for now as the quick fix.
## [17.0.3](v17.0.2...v17.0.3) (2026-02-17) ### Bug Fixes * escape image alt text ([#3896](#3896)) ([909fe44](909fe44))
Marked version: 17.0.2
Description
Escape image alt text. This bug was introduced in v15.0.0
Contributor
Committer
In most cases, this should be a different person than the contributor.