Skip to content

fix: fix blockquote after list#3888

Merged
UziTech merged 1 commit intomarkedjs:masterfrom
UziTech:blockquote-after-list
Feb 11, 2026
Merged

fix: fix blockquote after list#3888
UziTech merged 1 commit intomarkedjs:masterfrom
UziTech:blockquote-after-list

Conversation

@UziTech
Copy link
Member

@UziTech UziTech commented Feb 8, 2026

Marked version: 17.0.1

Description

Fix blockquote after list

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Feb 8, 2026

@UziTech is attempting to deploy a commit to the MarkedJS Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Feb 8, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
marked-website Ready Ready Preview, Comment Feb 8, 2026 10:53pm

Request Review

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Feb 8, 2026

Summary of Changes

Hello @UziTech, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a parsing error in the Markdown tokenizer that previously misidentified blockquotes appearing directly after list items. By enhancing the tokenizer's ability to recognize blockquote beginnings and properly terminate list contexts, the change ensures that complex Markdown structures involving lists and blockquotes are rendered accurately. This improvement contributes to the overall robustness and correctness of the Markdown parsing engine.

Highlights

  • Blockquote Parsing Fix: Corrected an issue where blockquotes immediately following a list item were not properly parsed, ensuring correct rendering of nested structures.
  • New Regex Rule: Introduced blockquoteBeginRegex in src/rules.ts to accurately identify the start of a blockquote, respecting indentation levels.
  • Tokenizer Logic Update: Modified the Tokenizer to use the new blockquoteBeginRegex to terminate list items when a blockquote is encountered, preventing incorrect nesting.
  • Comprehensive Test Coverage: Added new test files (nested_blockquote_in_list.md and nested_blockquote_in_list.html) to validate the fix across various nesting scenarios.
Changelog
  • src/Tokenizer.ts
    • Added blockquoteBeginRegex to the set of regular expressions used for identifying structural elements.
    • Implemented a new condition to end a list item's parsing if a blockquote pattern is detected on the subsequent line.
  • src/rules.ts
    • Introduced a new utility function, blockquoteBeginRegex, which generates a regular expression to match the start of a blockquote, taking into account indentation.
  • test/specs/new/nested_blockquote_in_list.html
    • New test file added to verify the expected HTML output for Markdown input containing blockquotes after list items.
  • test/specs/new/nested_blockquote_in_list.md
    • New test file added containing Markdown examples that demonstrate blockquotes nested within and following list items, used to validate the parsing fix.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Feb 8, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue where blockquotes were not being properly parsed after a list by introducing a check to terminate the list item parsing. The addition of new test cases to cover child, sibling, and parent-level blockquotes is excellent and ensures the fix is robust. My review includes a couple of suggestions to improve maintainability by refactoring duplicated code patterns that were expanded by this change. While the current implementation works, addressing these points would make the code more concise and easier to maintain in the future.

@UziTech UziTech force-pushed the blockquote-after-list branch from af440df to 617d024 Compare February 8, 2026 22:33
@UziTech UziTech merged commit 2a475a1 into markedjs:master Feb 11, 2026
8 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 11, 2026
@semantic-release-bot
chore(release): 17.0.2 [skip ci]
e824620 
## [17.0.2](v17.0.1...v17.0.2) (2026-02-11)

### Bug Fixes

* fix blockquote after list ([#3888](#3888)) ([2a475a1](2a475a1))
* fix empty list item ([#3890](#3890)) ([3fc6a44](3fc6a44))
* fix list item wrong indent ([#3889](#3889)) ([e031175](e031175))
* fix list with tabs ([#3891](#3891)) ([9fc4f8e](9fc4f8e))
* fix strikethrough flanking rules ([#3882](#3882)) ([1a5b124](1a5b124))
@UziTech UziTech deleted the blockquote-after-list branch March 6, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@styfle styfle styfle approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Quoteblocks in lists strongly assume child of above list item

2 participants

@UziTech @styfle