Skip to content

Improve renderHTML and TexPlugin#2

Merged
akshayka merged 1 commit into
mainfrom
ms/improverenderHTML
Aug 15, 2023
Merged

Improve renderHTML and TexPlugin#2
akshayka merged 1 commit into
mainfrom
ms/improverenderHTML

Conversation

@mscolnick

@mscolnick mscolnick commented Aug 14, 2023

Copy link
Copy Markdown
Contributor
  • This improves the TexPlugin to grab the already rendered HTML from the mounted element instead of re-rendering inside the shadow dom.
  • this also changes RenderHTML from a react component to function, which simplifies the WebComponent created in registerReactComponent

@vercel

vercel Bot commented Aug 14, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview Aug 14, 2023 9:38pm

@mscolnick mscolnick requested a review from akshayka August 14, 2023 21:38

@akshayka akshayka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, love the simplification.

Comment thread Makefile
# test frontend
fe-test:
cd frontend; pnpm test
cd frontend; CI=true pnpm test

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

@akshayka akshayka merged commit 7aa9a04 into main Aug 15, 2023
@akshayka akshayka deleted the ms/improverenderHTML branch August 15, 2023 03:58
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants