Add pre-commit hook and make install-hooks target#52
Merged
Conversation
- scripts/pre-commit.sh: checks gofmt on staged .go files, go vet, go build - make install-hooks: symlinks hook into .git/hooks/pre-commit - README: document make install-hooks in dev section Same pattern as nightshift and sidecar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a git pre-commit hook matching the pattern recently landed in nightshift and sidecar.
Changes
scripts/pre-commit.sh— checks gofmt on staged.gofiles,go vet,go buildmake install-hooks— symlinks the hook into.git/hooks/pre-commitmake install-hooksin the dev sectionHow to test
make install-hooks # stage a .go file and commit — hook should run