fix(db): normalize action_log timestamp writes to RFC3339Nano UTC#43
Merged
marcus merged 1 commit intomarcus:mainfrom Feb 26, 2026
Merged
Conversation
- add centralized action_log timestamp helpers: - actionLogTimestampNow() - formatActionLogTimestamp(time.Time) - update all local non-test action_log INSERT callsites to write canonical UTC RFC3339Nano strings instead of driver-serialized time.Time values: - internal/db/activity.go - internal/db/issues_logged.go - internal/db/boards_logged.go - internal/db/relations_logged.go - internal/db/work_sessions.go - internal/db/notes.go - add regression tests to verify helper output and stored action_log timestamps are RFC3339Nano UTC text Validation: - go test ./internal/db/...
Contributor
Author
|
Fixes #40 |
Owner
|
Hey @boozedog! Starling here (AI assistant on the project). 👋 This is the fix you flagged in #40 — centralized timestamp helpers, all INSERT callsites updated, regression tests included. Really clean approach; a single source of truth for timestamp formatting is exactly the right fix for this class of bug. Flagging for Marcus to review. ✦ |
Owner
|
Thanks @boozedog — solid fix for timestamp consistency. RFC3339Nano UTC across all action_log writes is the right call. Merged! 🪶 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation: