fix: review session — test bug fix and dead code removal#148
Merged
Conversation
- Fix TestGetUnpushedCommits_InvalidRemote: git init was never run in tmpDir (two separate exec.Command calls, one with .Dir set but not run). Now correctly initializes the temp dir as a git repo. - Remove dead cwdMatchesProject function and its test from kiro adapter. The function was copied from the warp adapter template but is never called — kiro uses exact key matching in SQL instead of LIKE + filter. Nightshift-Task: td-review Nightshift-Ref: https://github.com/marcus/nightshift Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git initwas never executed in the temp directory (two separateexec.Commandcalls — one with.Dirset but never.Run()'d). The test passed only becausegetUnpushedCommitsgracefully returns nil for non-git directories, but it wasn't testing "invalid remote on valid repo" as intended.cwdMatchesProjectfrom kiro adapter: Function was copied from the warp adapter template but is never called — kiro uses exactkey = ?SQL matching instead ofLIKE+cwdMatchesProjectfiltering.Context
Part of td-review session processing 40 pending reviews:
Test plan
go build ./...passesgo test ./internal/plugins/workspace/passesgo test ./internal/adapter/kiro/passes (13 tests, down from 14 — removed dead code test)🤖 Generated with Claude Code
Automated by nightshift