Skip to content

fix: address linting errors#117

Merged
marcus merged 1 commit intomainfrom
fix/linter-errors
Feb 11, 2026
Merged

fix: address linting errors#117
marcus merged 1 commit intomainfrom
fix/linter-errors

Conversation

@marcus
Copy link
Owner

@marcus marcus commented Feb 10, 2026

Summary

  • Fixed 24 linting errors: 23 errcheck + 1 ineffassign
  • All errors handled appropriately:
    • Unchecked function returns: handled with blank identifier (_ = ) in test contexts where errors are safely ignored
    • Ineffassign: removed unused initial assignment in conditionals

Files Modified

  • cmd/sidecar/main.go: Handle os.Unsetenv error
  • internal/adapter/amp/adapter_test.go: Handle os.MkdirAll errors
  • internal/adapter/kiro/kiro_test.go: Handle os.MkdirAll and os.WriteFile errors
  • internal/plugins/workspace/diff_test.go: Handle exec.Cmd.Run and os.WriteFile errors
  • internal/plugins/conversations/view_content.go: Fix ineffassign by using var declaration

Test Plan

  • Tests pass (go test ./...)
  • Code builds successfully (go build ./...)
  • No more errcheck/ineffassign errors reported by golangci-lint

🤖 Generated with Claude Code

- cmd/sidecar/main.go: Handle os.Unsetenv error with blank identifier
- internal/adapter/amp/adapter_test.go: Handle os.MkdirAll errors in test helpers
- internal/adapter/kiro/kiro_test.go: Handle os.MkdirAll and os.WriteFile errors
- internal/plugins/workspace/diff_test.go: Handle exec.Cmd.Run and os.WriteFile errors
- internal/plugins/conversations/view_content.go: Fix ineffassign by using var declaration

All 24 linting errors (23 errcheck + 1 ineffassign) now resolved.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@marcus marcus merged commit 3e8779d into main Feb 11, 2026
2 checks passed
@marcus marcus deleted the fix/linter-errors branch February 11, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant