Skip to content

Conversation

@passsy
Copy link
Contributor

@passsy passsy commented Feb 28, 2020

Upgrading to Flutter 1.15.0 is breaks the TextOneLine Widget and prevents compilation.
flutter/flutter#48346

Since it is a breaking change I bumped the minor version as well.

@marcglasberg
Copy link
Owner

Thanks for the PR, Pascal. However the stable channel is now at 1.12.13-hotfix8, and if I accept your PR now I will break the stable. So, as I understand, I must wait until v1.15.0 goes stable, right? Or is there some way to upload code for future versions which I am not aware of?

@passsy
Copy link
Contributor Author

passsy commented Mar 1, 2020

I added flutter SDK version constraints. Users on stable will face the following error when they manually upgrade. Existing users will not upgrade because pub checks the environment constraints.

$ flutter packages get
The current Flutter SDK version is 1.14.6.                              
                                                                        
Because spitch depends on assorted_layout_widgets from git which requires Flutter SDK version ^1.15.0, version solving failed.
Running "flutter pub get" in myapp...                           
pub get failed (1; Because spitch depends on assorted_layout_widgets from git which requires Flutter SDK version ^1.15.0, version solving failed.)

@passsy
Copy link
Contributor Author

passsy commented Sep 16, 2020

Closing because support for Flutter 1.17 has been added a long time ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants