Exposing zoomFactor in options#162
Merged
marcbachmann merged 2 commits intomarcbachmann:masterfrom Aug 17, 2016
Merged
Conversation
added 2 commits
August 5, 2016 04:21
The zoomFactor is an important factor when rendering the webpage. Please expose it:)
Owner
|
Any idea what happened with the |
Contributor
Author
|
Not sure about that. At least for now DPI configuration is not working in its master branch. (Correct me if I'm wrong:)) If we don't configure the |
Owner
|
How do you use that? Do you use it only for images or also for pdfs? |
Owner
|
Released in v2.1.0 |
Contributor
Author
|
Thanks! We only use it for png/jpeg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zoomFactoris an important factor when rendering webpages, especially when the webpage is exported as png/jpg. Given that the dpi of the images rendered by PhantamJS is relatively low, many clients choose to adjust thezoomFactorto get better image quality.Therefore, I would like to expose this factor to clients.