Use cryptography's built-in PKCS7 padding functions#7
Closed
tannercollin wants to merge 1 commit intomaqp:masterfrom
Closed
Use cryptography's built-in PKCS7 padding functions#7tannercollin wants to merge 1 commit intomaqp:masterfrom
tannercollin wants to merge 1 commit intomaqp:masterfrom
Conversation
Owner
|
Thank you so much! The 1.19.04 now uses pyca/cryptography's PKCS7 implementation. I apologize I'm not able to trivially merge pull requests. This is because all source files have pinned hashes in the installer, which is signed using an airgapped system. So any update in the source requires updating the installer and its signature at the same time. I've credited you in the update log, I hope that's enough! |
Author
|
Absolutely! Thanks for the update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using cryptography's built-in padding functions is more readable than manually appending / removing the bytes.
I've tested the changes:
I assign all copyright for the changes to you :)