Skip to content

Update placeholder text, few links, typos#404

Merged
sarahcodes100 merged 1 commit intomapzen:masterfrom
rmglennon:master
Jun 27, 2017
Merged

Update placeholder text, few links, typos#404
sarahcodes100 merged 1 commit intomapzen:masterfrom
rmglennon:master

Conversation

@rmglennon
Copy link
Copy Markdown
Member

@rmglennon rmglennon commented Jun 19, 2017

These changes are part of mapzen/documentation#310

This updates the placeholder text to use your-mapzen-api-key (please make sure I didn't accidentally remove required quotation marks or anything like that) so it can be automatically replaced when signed in.

I also deleted some text that describes how to use the placeholder text (like replace it with your real key) because the key is already replaced when signed in, and the pop-up over the text will be the call to action for users who are not signed in.

There were also a few minor style (change "we" to you or third-party) and typo issues that I happened to see.

@karimnaaji karimnaaji requested review from ecgreb and removed request for ecgreb June 20, 2017 00:46
@rmglennon rmglennon changed the title Do not merge yet - Update placeholder text, few links, typos Update placeholder text, few links, typos Jun 21, 2017
@rmglennon
Copy link
Copy Markdown
Member Author

This is ready for review and merge. You can look at the raw markdown to verify changes, or check out the preview if you want to see what happens.

Expected behavior:
When you are signed in, any instances of placeholder API key text is replaced with the first API key in your account.

When you are not signed in, or are signed in but have no API keys, you will continue to see placeholder text ("your-mapzen-api-key")...more enhancements coming to the placeholder text.

Preview (let me know if you need credentials):
https://dev.mapzen.com/documentation/android/getting-started/
https://dev.mapzen.com/documentation/android/search/
https://dev.mapzen.com/documentation/android/turn-by-turn/

@rmglennon
Copy link
Copy Markdown
Member Author

Changing this back to DO NOT MERGE YET status. Results of testing are inconsistent.

@rmglennon rmglennon changed the title Update placeholder text, few links, typos Do not merge yet - Update placeholder text, few links, typos Jun 21, 2017
@rmglennon rmglennon changed the title Do not merge yet - Update placeholder text, few links, typos Update placeholder text, few links, typos Jun 26, 2017
@rmglennon
Copy link
Copy Markdown
Member Author

After discussion with @louh, we should go ahead and review and merge this PR to complete the work on the content side of this project.

Remaining issues are with the code and are being tracked in mapzen/documentation#312.

@sarahcodes100
Copy link
Copy Markdown
Member

These changes look nice!

@sarahcodes100 sarahcodes100 merged commit 670556c into mapzen:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants