#3574 Respect only explicit mappings but fail on unmapped source fields #3632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce fields This reverts mapstruct#2560, because we've decided that `@BeanMapping(ignoreByDefault = true)` should only be applied to target properties and not to source properties. Source properties are anyway ignored, the `BeanMapping#unmappedSourcePolicy` should be used to control what should happen with unmapped source policy
thunderhook
requested changes
Jul 1, 2024
Contributor
thunderhook
left a comment
There was a problem hiding this comment.
Just a few nit picky notes, and of course Checkstyle makes an appearance 😉
documentation/src/main/asciidoc/chapter-10-advanced-mapping-options.asciidoc
Outdated
Show resolved
Hide resolved
documentation/src/main/asciidoc/chapter-10-advanced-mapping-options.asciidoc
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks for the feedback @thunderhook. I've applied the changes |
thunderhook
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #2560, because we've decided that
@BeanMapping(ignoreByDefault = true)should only be applied to target properties and not to source properties. Source properties are anyway ignored, theBeanMapping#unmappedSourcePolicyshould be used to control what should happen with unmapped source policyFixes #3574