#3524 provide tests with delomboked classes annotated with lomboks @SuperBuilder annotation #3542
Conversation
filiphr
left a comment
There was a problem hiding this comment.
Thanks @thunderhook, this looks OK to me. I have only one small request. Let's remove Lombok from the package the javadoc. This is about a super builder, so let's only keep that in the naming. Let's also remove the things that are not needed for the tests like the equals and hashCode methods.
There was a problem hiding this comment.
Do we really need a package-info.java for this?
|
@filiphr Thanks for the suggestions. I tried to keep it as "original" as possible, hence the equals/hashCode, but no problem. I will remove it. The So just name the package `org.mapstruct.ap.test.superbuilder' and remove any trace of Lombok? |
Indeed, rename the package and remove the Lombok traces. Try to limit it to the minimum that we need to test super builders. Thanks |
|
Thanks @thunderhook |
Haven't found that many different scenarios. I hope it's enough to show that it works.
If you have any further wishes or suggestions, please let me know.
Closes #3524