#3199 Add support for implicit conversion between java.time.LocalDate and java.time.LocalDateTime #3254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LocalDate and java.time.LocalDateTime
filiphr
approved these changes
Apr 26, 2023
Member
filiphr
left a comment
There was a problem hiding this comment.
Thanks @Bragolgirith. It looks good to me. I only have one small question
processor/src/main/java/org/mapstruct/ap/internal/conversion/Conversions.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Also, there were some CI workflow run failures last time, e.g.: These seem unrelated to the PR - maybe a one-time connectivity issue or a proxy configuration issue? |
Member
|
Thanks for your changes @Bragolgirith.
Those are some recurring flaky errors we are getting on our CI. I ignore those errors. I'll merge this once the final build is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3199
Took the liberty of creating a PR.
First time contributing to the project, so do tell if I've missed something!