#2897 Always import types defined in Mapper#imports
#2972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjaakd
approved these changes
Aug 23, 2022
Contributor
sjaakd
left a comment
There was a problem hiding this comment.
suggestion for naming added
|
|
||
| for ( TypeMirror extraImport : mapperOptions.imports() ) { | ||
| Type type = typeFactory.getType( extraImport ); | ||
| Type type = typeFactory.getAlwaysImportedType( extraImport ); |
Contributor
There was a problem hiding this comment.
Would explicit be a better term? Or even explicitImportByMappingAnnotation..
Member
Author
There was a problem hiding this comment.
I named it getAlwaysImportedType because we might need to use it for something else in the future. You never know what can happen.
I'll add Javadoc though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2897