Closed
Conversation
|
Looking forward to see this PR merged. This will help with some custom plugins we created. |
Author
|
closed in favor of #976 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not as intrusive as #976 but supports mapnik built with cmake. (since the cmake build only supports
pkg-configbut notmapnik-configsee mapnik/mapnik#4256 for more info on that topic)This PR depends currently on the proj6 branches. It should be pretty simple to test if you have docker installed:
The docker container also runs the
npm run testcommand to verify the build.@springmeyer / @artemp I don't really know how to change the
binding.gypin a way that it supports bothmapnik-configandpkg-config.