Skip to content

Add Dockerfile and installation instructions#4153

Open
hiddewie wants to merge 2 commits intomapnik:v3.0.xfrom
hiddewie:dockerfile
Open

Add Dockerfile and installation instructions#4153
hiddewie wants to merge 2 commits intomapnik:v3.0.xfrom
hiddewie:dockerfile

Conversation

@hiddewie
Copy link
Copy Markdown

@hiddewie hiddewie commented Jun 14, 2020

Based on https://github.com/jawg/docker-mapnik3 and jawg/docker-mapnik3#8. Usage of Apache licensed software (the image build instructions in this case) should be fine if the Apache License is mentioned explicitly (it is in this PR).

This PR should fix #3704.

Travis integration is still needed: https://docs.travis-ci.com/user/docker/#building-a-docker-image-from-a-dockerfile

The Python and Node bindings could have their own Docker image which also compile those bindings into a derived image.

Each 'main' branch of the project should have it's own image, in particular each release.

@hiddewie hiddewie changed the base branch from master to v3.0.x June 14, 2020 14:33
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 14, 2020

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.02%. Comparing base (b94f00f) to head (ec97a02).
⚠️ Report is 14 commits behind head on v3.0.x.

Additional details and impacted files
@@            Coverage Diff             @@
##           v3.0.x    #4153      +/-   ##
==========================================
- Coverage   68.96%   67.02%   -1.94%     
==========================================
  Files         446      446              
  Lines       22984    22324     -660     
==========================================
- Hits        15851    14963     -888     
- Misses       7133     7361     +228     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hiddewie
Copy link
Copy Markdown
Author

I have no idea why the code coverage would change for this PR. It does not touch the source or tests.

@Sieboldianus
Copy link
Copy Markdown

Sieboldianus commented Jul 14, 2022

Based on https://github.com/jawg/docker-mapnik3 and jawg/docker-mapnik3#8. Usage of Apache licensed software (the image build instructions in this case) should be fine if the Apache License is mentioned explicitly (it is in this PR).

This PR should fix #3704.

Travis integration is still needed: https://docs.travis-ci.com/user/docker/#building-a-docker-image-from-a-dockerfile

The Python and Node bindings could have their own Docker image which also compile those bindings into a derived image.

Each 'main' branch of the project should have it's own image, in particular each release.

Many thanks for the Dockerfile. Did you test to include the python-bindings in the Dockerimage? I have tried, but did not suceed so far.

@Sieboldianus
Copy link
Copy Markdown

Here's a (tested) Dockerfile that adds python-bindings to mapnik3 docker from jawg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Official Docker images for Mapnik?

2 participants