Skip to content

Fix WebGL cube and editor examples #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 3 commits into from
Sep 9, 2021
Merged

Fix WebGL cube and editor examples #467

oscarlorentzon merged 3 commits into from
Sep 9, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Sep 9, 2021

Motivation

Fix documentation example functionality.

Contribution

  • Use depth test for correct WebGL cube rendering
  • Compute projection matrix inverse on each camera update for correct editor example raycasting

Test Plan

yarn --cwd doc ci
yarn --cwd doc rebuild
yarn --cwd doc serve

@oscarlorentzon
fix: use depth test for webgl cube rendering
738c394
@oscarlorentzon
fix: correct raycasting for editor
873cca8 
Compute projection matrix inverse to ensure
that raycasting is performed correctly for
editor objects.
@oscarlorentzon
chore: update docusaurus to 2.0.0-beta.6
223fb6e
@oscarlorentzon oscarlorentzon added this to the v4.1.0 milestone Sep 9, 2021
@oscarlorentzon oscarlorentzon merged commit e18160e into main Sep 9, 2021
@oscarlorentzon oscarlorentzon deleted the feature-doc-fixes branch September 9, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot