Skip to content

Render spherical camera frames #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 1 commit into from
Sep 1, 2021
Merged

Render spherical camera frames #464

oscarlorentzon merged 1 commit into from
Sep 1, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Sep 1, 2021

Contribution & Motivation

Render camera frame lines on a sphere instead
of a plane to avoid large star shapes for
short focal lengths.

Test Plan

yarn build
yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the v4.1.0 milestone Sep 1, 2021
@oscarlorentzon
fix(spatial): render spherical camera frames
a50a912 
Render camera frame lines on a sphere instead
of a plane to avoid large star shapes for
short focal lengths.
@oscarlorentzon oscarlorentzon merged commit 7292966 into main Sep 1, 2021
@oscarlorentzon oscarlorentzon deleted the feature-camera-frames branch September 1, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot