Skip to content

Improve initial earth state positioning #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 1 commit into from
May 12, 2021
Merged

Improve initial earth state positioning #398

oscarlorentzon merged 1 commit into from
May 12, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented May 12, 2021

Try to keep forward direction if possible.
Unify earth positioning across library.

Motivation

Always give a good overview when transitioning to earth camera controls

Contribution

  • Adaptive positioning based on viewing direction

Test Plan

yarn lint
yarn build
yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone May 12, 2021
@oscarlorentzon
feat: improve initial earth state positioning
a55104b 
Try to keep forward direction if possible.
Unify earth positioning across library.
@oscarlorentzon oscarlorentzon merged commit 15b7798 into main May 12, 2021
@oscarlorentzon oscarlorentzon deleted the feature-earth-init branch May 12, 2021 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot