Skip to content

Make minimum tile level requests for lower levels #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 1 commit into from
May 3, 2021
Merged

Make minimum tile level requests for lower levels #386

oscarlorentzon merged 1 commit into from
May 3, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented May 3, 2021

Ensure that tiles are always requested.

Motivation

Avoid potential aliasing.

Contribution

  • Request the minimum supported tile level when a lower tile level is set.

Test Plan

yarn build
yarn test
yarn start

@oscarlorentzon
feat: clamp tile level with min request level
5d641dd 
Ensure that tiles are always requested.
@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone May 3, 2021
@oscarlorentzon oscarlorentzon merged commit 4ddab59 into main May 3, 2021
@oscarlorentzon oscarlorentzon deleted the feature-tile-clamp branch May 3, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot