Skip to content

Fix rendering for spherical images with non valid scale #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 1 commit into from
Apr 29, 2021
Merged

Fix rendering for spherical images with non valid scale #378

oscarlorentzon merged 1 commit into from
Apr 29, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Apr 29, 2021

Motivation

Ensure that spherical images with non valid scale are rendered correctly.

Contribution

Test Plan

yarn lint 
yarn build
yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Apr 29, 2021
@oscarlorentzon oscarlorentzon merged commit e3237b8 into main Apr 29, 2021
@oscarlorentzon oscarlorentzon deleted the feature-mesh-factory branch April 29, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot