Skip to content

Consolidate API #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 13 commits into from
Apr 23, 2021
Merged

Consolidate API #367

oscarlorentzon merged 13 commits into from
Apr 23, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Apr 23, 2021

Motivation

Unify API types, interfaces, and naming.

Contribution

  • Export everything without namespacing for improved intellisense, development feedback, and simplicity
  • Simplify component names
  • Separate fallback component options and clarify names
  • Remove redundant and obsolete API properties for spatial configuration, cluster contract
  • Fix filtering types
  • Rename merge_cc to merge_id and make string instead of number for unification
  • Type component names
  • Fix event names

Test Plan

yarn lint
yarn build
yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Apr 23, 2021
@oscarlorentzon oscarlorentzon merged commit 08ccde0 into main Apr 23, 2021
@oscarlorentzon oscarlorentzon deleted the feature-public-api branch April 23, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot