Skip to content

Typed event handlers #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 6 commits into from
Mar 28, 2021
Merged

Typed event handlers #360

oscarlorentzon merged 6 commits into from
Mar 28, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Mar 28, 2021

Motivation

Simplify event subscription and improve event reference documentation

Contribution

  • Typed and documented event handler method overloads

Test Plan

yarn prepare
yarn test

@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Mar 28, 2021
@oscarlorentzon oscarlorentzon merged commit 4efa09a into main Mar 28, 2021
@oscarlorentzon oscarlorentzon deleted the feature-event-types branch March 28, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot