Skip to content

Consolidate geometry provider #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 3 commits into from
Mar 27, 2021
Merged

Consolidate geometry provider #357

oscarlorentzon merged 3 commits into from
Mar 27, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Mar 27, 2021

Motivation

  • Make geometry provider API simpler

Contribution

  • Remove redundant methods and parameters
  • Rename methods for clarity
  • Simplify return values
  • Move reusable code to base class
  • Improve test coverage

Test Plan

yarn prepare
yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Mar 27, 2021
@oscarlorentzon oscarlorentzon merged commit d318d4e into main Mar 27, 2021
@oscarlorentzon oscarlorentzon deleted the feature-geometry-provider branch March 27, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot