Skip to content

Viewer option to inactivate image tiling #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 1 commit into from
Mar 25, 2021
Merged

Viewer option to inactivate image tiling #352

oscarlorentzon merged 1 commit into from
Mar 25, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Mar 25, 2021

Motivation

Can be used when extending mapillary-js with a custom data provider. If no image tiling server exists the image tiling can be inactivated to avoid error messages about non-existing tiles in the console.

Contribution

Add boolean viewer option to disable image tiling.

Test Plan

yarn prepare
yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Mar 25, 2021
@oscarlorentzon oscarlorentzon force-pushed the feature-tiling-option branch from ab57981 to adb486c Compare March 25, 2021 11:28
@oscarlorentzon oscarlorentzon force-pushed the feature-tiling-option branch from adb486c to 955bed2 Compare March 25, 2021 11:34
@oscarlorentzon oscarlorentzon merged commit e6ef502 into main Mar 25, 2021
@oscarlorentzon oscarlorentzon deleted the feature-tiling-option branch March 25, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot