Skip to content

Unified component event structure #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 1 commit into from
Mar 23, 2021
Merged

Unified component event structure #347

oscarlorentzon merged 1 commit into from
Mar 23, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Mar 23, 2021 •
edited
Loading

Remove all component configuration wrapper APIs
to avoid duplicated logic.
Remove all unsupported public observables.

Motivation

Simplify component API usage.

Contribution

  • Document all events
  • Extend event interface for common event structure

Test Plan

yarn prepare
yarn test
yarn start

Navigate to http://localhost:8000

@oscarlorentzon
refactor: type and document component events
b2b688c 
Remove all component configuration wrapper APIs
to avoid duplicated logic.
Remove all unsupported public observables.
@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Mar 23, 2021
@oscarlorentzon oscarlorentzon merged commit 2fa2cb8 into main Mar 23, 2021
@oscarlorentzon oscarlorentzon deleted the feature-component-events branch March 23, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot