Refactor interfaces, events, data contracts, extension APIs and properties #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve performance for tags, popups, spatial, render camera etc by avoiding costly matrix inversion for each unproject.
Move image size enum to Falcor namespace because it is only relevant there. Do not fetch higher res image on halt. Make thumb and mesh url ents.
Document behavior if props not set.
Only opaque exist so far.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Public API that has clearer types, better documentation, and improved property names.
Contribution
Rename interfaces, document events, change property names, change property types.
Test Plan