Skip to content

Handle fisheye origin singularity #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 1 commit into from
Mar 9, 2021
Merged

Handle fisheye origin singularity #339

oscarlorentzon merged 1 commit into from
Mar 9, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Mar 9, 2021 •
edited
Loading

Motivation

Ensure that the sfmToBearing calculations handles singularities and avoids outputting NaNs.

Contribution

Checks if the denominator is small and falls back to 1 if that is the case.

See OpenSfM camera functions for a reference.

Test Plan

yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Mar 9, 2021
@oscarlorentzon oscarlorentzon merged commit b837b02 into main Mar 9, 2021
@oscarlorentzon oscarlorentzon deleted the feature-fisheye-singularity branch March 9, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot