Skip to content

Feature spatial filter #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 2 commits into from
Mar 9, 2021
Merged

Feature spatial filter #338

oscarlorentzon merged 2 commits into from
Mar 9, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Mar 9, 2021

Motivation

When filtering all nodes of a reconstruction cluster the cluster points should also be filtered and hidden.

Contribution

  • Hide original positions when cameras are hidden
  • Hide point clouds when all cameras related to the point cloud are hidden

Test Plan

yarn prepare
yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Mar 9, 2021
@oscarlorentzon oscarlorentzon merged commit 4981d2f into main Mar 9, 2021
@oscarlorentzon oscarlorentzon deleted the feature-spatial-filter branch March 9, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot