Skip to content

Custom render API #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oscarlorentzon merged 2 commits into from
Mar 2, 2021
Merged

Custom render API #336

oscarlorentzon merged 2 commits into from
Mar 2, 2021

Conversation

@oscarlorentzon
Copy link
Member

@oscarlorentzon oscarlorentzon commented Mar 2, 2021

Motivation

Make it possible to augment the street imagery viewing experience with any content.

Contribution

Custom render API that allows adding custom renderers, implemented outside of MapillaryJS, to the render pipeline.

Test Plan

yarn prepare
yarn test
yarn start

@oscarlorentzon
feat(render): add custom renderer api
173ed0b 
Document public entities.
@oscarlorentzon
test(render): test custom rendering logic
c7dd182 
Test triggered gl rendering, viewer custom renderer methods
and custom renderer.
@oscarlorentzon oscarlorentzon added this to the 4.0.0 milestone Mar 2, 2021
@oscarlorentzon oscarlorentzon merged commit 8fd61c9 into main Mar 2, 2021
@oscarlorentzon oscarlorentzon deleted the feature-custom-renderer branch March 2, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscarlorentzon @facebook-github-bot