fix: use map views ref counts #822
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: `Map` data such as `shots` is exposed through view classes. We need to keep the map alive as long as some of its objects are alive in python. For this to happen, we need - make the views keep alive the map - make the shots keep alive the view A better solution will be to use pybind's own bindings for `unordered_map`. However, this is only complete in pybind 2.8 pybind/pybind11#3310 Differential Revision: D32401524 fbshipit-source-id: 3fc30e710a2151dbb5097de8fe685ddfa80df675
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D32401524 |
Contributor
|
This pull request has been merged in 547a278. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Mapdata such asshotsis exposed through view classes. We need to keep the map alive as long as some of its objects are alive in python. For this to happen, we needA better solution will be to use pybind's own bindings for
unordered_map. However, this is only complete in pybind 2.8 pybind/pybind11#3310Differential Revision: D32401524